-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace standard deviation in operator estimation with standard error #870
Conversation
Did you use a lorem ipsum generator for the title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@joshcombes any thoughts? |
@notmgsk Watch out, my next few PRs are going to be titled Expecto patronum, Wingardium Leviosa and hocus pocus. |
All (@notmgsk, @marcusps, @joshcombes), I'd like to merge this in and move to other PRs. If there's any other thing you'd like to add to this one, please do so by tomorrow or forever hold your peace! |
So this will break any code that uses these attributes, but I guess we're assuming that most of our users are internal for this feature set? |
@karalekas Correct. The only other place that I'm aware of where this code is used is in forest-benchmarking. I've created a separate PR for forest-benchmarking (rigetti/forest-benchmarking#88) that would resolve any breaking changes in forest-benchmarking caused by merging this PR. |
Resolves Issue #864. Also introduces a few other minor cosmetic changes:
readout_symmetrize
tosymmetrize_readout
inmeasure_observables(..)
, to make it read more similar to the optional argumentcalibrate_readout
_exhaustive_symmetrization
to use f-strings instead of the old way of usingformat