Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace standard deviation in operator estimation with standard error #870

Merged
merged 4 commits into from
Apr 19, 2019

Conversation

msohaibalam
Copy link
Contributor

Resolves Issue #864. Also introduces a few other minor cosmetic changes:

  • Changes the name of the optional argument readout_symmetrize to symmetrize_readout in measure_observables(..), to make it read more similar to the optional argument calibrate_readout
  • Updates the warning message in _exhaustive_symmetrization to use f-strings instead of the old way of using format

@msohaibalam msohaibalam requested a review from a team as a code owner April 3, 2019 00:05
@msohaibalam msohaibalam requested a review from marcusps April 3, 2019 00:05
@notmgsk
Copy link
Contributor

notmgsk commented Apr 3, 2019

Did you use a lorem ipsum generator for the title

@marcusps marcusps changed the title Op est std err Replace standard deviation in operator estimation with standard error Apr 4, 2019
@marcusps marcusps requested a review from joshcombes April 4, 2019 03:53
Copy link
Contributor

@marcusps marcusps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusps
Copy link
Contributor

marcusps commented Apr 4, 2019

@joshcombes any thoughts?

@msohaibalam
Copy link
Contributor Author

msohaibalam commented Apr 4, 2019

Did you use a lorem ipsum generator for the title

@notmgsk Watch out, my next few PRs are going to be titled Expecto patronum, Wingardium Leviosa and hocus pocus.

@msohaibalam
Copy link
Contributor Author

All (@notmgsk, @marcusps, @joshcombes), I'd like to merge this in and move to other PRs. If there's any other thing you'd like to add to this one, please do so by tomorrow or forever hold your peace!

@karalekas
Copy link
Contributor

So this will break any code that uses these attributes, but I guess we're assuming that most of our users are internal for this feature set?

@msohaibalam
Copy link
Contributor Author

@karalekas Correct. The only other place that I'm aware of where this code is used is in forest-benchmarking. I've created a separate PR for forest-benchmarking (rigetti/forest-benchmarking#88) that would resolve any breaking changes in forest-benchmarking caused by merging this PR.

@karalekas karalekas merged commit d8d9f92 into rigetti:master Apr 19, 2019
@karalekas karalekas added this to the v2.7.0 milestone Apr 29, 2019
@msohaibalam msohaibalam deleted the op-est-std-err branch April 30, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants