Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase gRPC max message size from 4MB to 50MB #468

Merged
merged 3 commits into from
May 10, 2024

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented May 9, 2024

Increases the gRPC max message size from 4MB (the tonic default) to 50MB. This is motivated by some users having hit the 4MB limit.

This MR also fixes a number of new clippy lints that were causing CI to fail.

Closes #467.

@notmgsk notmgsk requested a review from MarquessV May 9, 2024 12:20
Copy link

github-actions bot commented May 9, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-10 18:07 UTC

@notmgsk notmgsk marked this pull request as ready for review May 9, 2024 13:29
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought, but happy to see this merged with whatever you decide!

crates/lib/src/client.rs Show resolved Hide resolved
@notmgsk notmgsk enabled auto-merge (squash) May 10, 2024 14:16
@notmgsk notmgsk merged commit c6af91e into main May 10, 2024
2 checks passed
@notmgsk notmgsk deleted the 467-increase-max-message-size-translation branch May 10, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase gRPC max message size limit for translation
2 participants