Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): ConnectionStrategy supports the pickle module #486

Merged
merged 3 commits into from
Jul 29, 2024
Merged

feat(python): ConnectionStrategy supports the pickle module #486

merged 3 commits into from
Jul 29, 2024

Conversation

MarquessV
Copy link
Contributor

This is to support rigetti/pyquil#1719

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-29 17:02 UTC

@MarquessV MarquessV marked this pull request as ready for review July 29, 2024 15:56
antalsz
antalsz requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@antalsz antalsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a missing assert in one of the tests, but the implementations look good. Also the branch name is incredible.

crates/python/src/qpu/api.rs Outdated Show resolved Hide resolved
crates/python/tests/qpu/test_api.py Show resolved Hide resolved
antalsz
antalsz approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@antalsz antalsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MarquessV MarquessV merged commit 4df4ce3 into main Jul 29, 2024
2 checks passed
@MarquessV MarquessV deleted the mas-escabeche branch July 29, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antalsz antalsz antalsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarquessV @antalsz