-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore function call casing, persist parameter %
#175
Merged
MarquessV
merged 10 commits into
1455-python-support-for-program-and-beyond
from
174-fix-expression-defgate-parsing
Mar 23, 2023
Merged
Ignore function call casing, persist parameter %
#175
MarquessV
merged 10 commits into
1455-python-support-for-program-and-beyond
from
174-fix-expression-defgate-parsing
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarquessV
changed the title
174 fix expression defgate parsing
Ignore function call casing, persist parameter Mar 21, 2023
%
Shadow53
reviewed
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about the use of r""
over ""
in a couple places, otherwise this looks fine to me.
kalzoo
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues to solve here:
This may be controversial. The Quil spec only ever refers to
cis
in a lowercase form. I've created this issue for clarification in the spec.Parameters for
GateDefintion
andWaveDefinition
are stored in aVec<String>
. These parameters are Quil identifiers prefixed with a%
(aka "formal parameters). The parser recognizes these as formal parameters, but stores them on the instruction without the%
. This meant they were getting printed back out asQuil
without the%
, which is incorrect. This fix restores the%
on output,though it may make more sense to keep it in the parser.After further discussion we've decided to omit the%
as it is a delimiter for quil and doesn't need to be part of the internal representation of a parameter. I've added tests to confirm this approach works forGateDefinition
,MeasureCalibrationDefinition
andWaveformDefinition
.