feat: Initialize Instructions from a Quil string. Python Instructions support the pickle module.
#382
Conversation
|
…e is leftover input, or if the parsed instruction count is not exactly 1
| } | ||
| Ok(instructions.1[0].to_owned()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Are we good with this being part of the public API?
MarquessV
changed the title
pickle module.Instructions from a Quil string. Python Instructions support the pickle module.
| @@ -45,6 +45,66 @@ macro_rules! impl_to_quil { | |||
| }; | |||
| } | |||
|
|
|||
| /// Implements pickling for an instruction by implementing __getstate__ and __reduce__. | |||
There was a problem hiding this comment.
I know you link to the __reduce__ documentation below, but it would probably be better to link to that here as well, or even instead of doing it on __reduce__ itself.
There was a problem hiding this comment.
Updated the docstring per your comment.
|
This is great! I see there's already a test for |
Yeah, good eye. We already had a handwritten solution for |
This is to support pyQuil#1791
todo:
impl_pickle_for_instructioneverywhere.