White 13 05 acu114901 implement ephemeral library cookbook #1
Conversation
…ks inside vagrant
* Added support for google * Added logic for giving the stripe size with multiple ephemeral disks
| - name: rightimage-centos-6.4 | ||
| box: opscode-ubuntu-12.04 | ||
| box_url: https://opscode-vm-bento.s3.amazonaws.com/vagrant/opscode_ubuntu-12.04_provisionerless.box | ||
| - name: ubuntu-10.04 |
There was a problem hiding this comment.
Why is 10.04 included? I thought we were just testing against 12.04
There was a problem hiding this comment.
For our library cookbooks we are testing for the default set of OSes as well.
There was a problem hiding this comment.
okay - this is different that my conversation with Lopaka.
So our plan moving forward is to support all of the OS's the community supports plus the additional ones we want to support.
Which means I need to add back in the default OS I removed from the setup_swap cookbook, And also add CentOS to the setup_syslog recipe
There was a problem hiding this comment.
This is a library cookbook.
What you and I talked about Erik was about 'application' cookbooks. Application cookbooks should be using the current OSs being developed by Ivory.
| module Helper | ||
| # Creates given loop devices | ||
| # | ||
| # @param devices [Array, String] the devices to create |
There was a problem hiding this comment.
I think you meant [Array<String>]?
There was a problem hiding this comment.
Oh, maybe not, but it should be specific and say [Array<String>, String].
| # ephemeral cookbook | ||
| # ephemeral_lvm cookbook | ||
|
|
||
| Sets up the ephemeral device(s) on a cloud instance to be an LVM device, formats the device, and mounts it. |
There was a problem hiding this comment.
It almost sounds like we are somehow configuring the existence of the ephemeral devices -- which is confusing because the cloud does that part -- we just detect if they are available. Perhaps reword a bit. For example, "Detects any ephemeral device(s) available to a cloud instance and configures them into a single LVM device, formats the device, and mounts it."
|
overall looks great!! A few comment to resolve.. |
| <tr> | ||
| <td><tt>node['ephemeral_lvm']['filesystem']</tt></td> | ||
| <td>The filesystem to be used on the ephemeral volume</td> | ||
| <td><tt>'ext3'</tt></td> |
There was a problem hiding this comment.
doesn't match default value set in attributes/default.rb.
|
A couple minor things. Nice work, @arangamani! |
|
Changes done again @caryp |
…_implement_ephemeral_library_cookbook White 13 05 acu114901 implement ephemeral library cookbook
|
nice work, @caryp! |
arangamani
deleted the
white_13_05_acu114901_implement_ephemeral_library_cookbook
branch
pulling back changes from rightscale-cookbooks/ephemeral_lvm
No description provided.