Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More diff.py improvements #196

Merged
merged 7 commits into from
Jul 8, 2022
Merged

More diff.py improvements #196

merged 7 commits into from
Jul 8, 2022

Conversation

SeekyCt
Copy link
Contributor

@SeekyCt SeekyCt commented Jul 8, 2022

  • Updated diff.py to the latest version from the original repo again (the update merged the arch_settings and mapfile regex changes this repo had into the main repo, and also added --stop-at-ret support for ppc to end the diff on the first blr found).
  • Set up this repo for .o diffing, which allows relocations with symbol names to be included in the diff (to use, run expected.py on an OK build and then use diff.py with -o)
  • Set up this repo for automatic rebuilding (run diff.py with the flags -mw and it will rebuild automatically whenever you edit the source code & update the diff, like on decomp.me)
  • Set up this repo for showing line numbers in the diff

@SeekyCt
Copy link
Contributor Author

SeekyCt commented Jul 8, 2022

Apparently matching breaks with -sym on rather than -sym dwarf-2, so I've undone that for now

@SeekyCt
Copy link
Contributor Author

SeekyCt commented Jul 8, 2022

Fixed line numbers for dwarf-2, so they're back again without breaking anything

@riptl
Copy link
Collaborator

riptl commented Jul 8, 2022

@SeekyCt Lgtm, is this ready to merge?

@SeekyCt
Copy link
Contributor Author

SeekyCt commented Jul 8, 2022

Yeah afaik

@riptl riptl merged commit 2ff919c into riidefi:master Jul 8, 2022
@riptl riptl added the devops Changes to the build system and CI label Jul 9, 2022
riidefi pushed a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Changes to the build system and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants