Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RaceConfig refactoring #233

Merged
merged 3 commits into from
Oct 14, 2022
Merged

RaceConfig refactoring #233

merged 3 commits into from
Oct 14, 2022

Conversation

vabold
Copy link
Contributor

@vabold vabold commented Oct 1, 2022

  • Moved competition structures to game/system/Competition.hpp
  • Renamed RaceConfigPlayer to RaceConfig::Player
  • Renamed RaceConfigSettings to RaceConfig::Settings
  • Renamed RaceConfigScenario to RaceConfig::Scenario
  • Organized header file, new structure is:
  1. Ctor, dtor/virtual functions
  2. Methods
  3. Getters
  4. Setters
  5. Inlines
  6. Static functions/static members
  7. Members

@riidefi
Copy link
Owner

riidefi commented Oct 14, 2022

LGTM

@riidefi riidefi merged commit d216160 into riidefi:master Oct 14, 2022
@vabold vabold deleted the refactor branch October 14, 2022 14:30
riidefi pushed a commit that referenced this pull request Feb 25, 2024
@vabold
RaceConfig refactoring (#233)
af13e1d 
* Class restructuring, file refactoring

* Fix formatting, remove unnecessary friend class

* Rename min16 to min32, move to rk_types.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riidefi riidefi riidefi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vabold @riidefi