Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RaceConfig wrap up #241

Merged
merged 7 commits into from
Oct 31, 2022
Merged

RaceConfig wrap up #241

merged 7 commits into from
Oct 31, 2022

Conversation

vabold
Copy link
Contributor

@vabold vabold commented Oct 17, 2022

Contingent on #240. This PR will serve as our stopping point for RaceConfig, as we move onto other classes.

  • Create enums
  • Rename GameType to CameraMode
  • Fix symbols
  • Change all outdated instances of s32 to their correct enum (on contingent PR merge)
  • Update scratch comments to furthest progress (on contingent PR merge)

@riidefi riidefi marked this pull request as ready for review October 31, 2022 07:58
@riidefi
Copy link
Owner

riidefi commented Oct 31, 2022

Merging. Feel free to update scratch links in a follow-up PR.

@riidefi riidefi merged commit c830db0 into riidefi:master Oct 31, 2022
riidefi pushed a commit that referenced this pull request Feb 25, 2024
* Create enums

* Rename GameType to CameraMode

* Fix symbols

* Pass build

* Change s32 to correct enums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants