Split CourseMap #243
Merged
Split CourseMap #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeekyCt
reviewed
Oct 22, 2022
| @@ -265,11 +265,6 @@ def disassemble_function(self, sym): | |||
| if addr not in self.extern_addrs: | |||
| self.extern_addrs.add(addr) | |||
|
|
|||
| # TODO: This is probably not where this should go | |||
There was a problem hiding this comment.
Was this fixed by your ppcdis change?
There was a problem hiding this comment.
rii added it probably to avoid adding function local symbols, since they would not exist on the symbol map. This was not needed now
vabold
reviewed
Oct 23, 2022
riidefi
pushed a commit
that referenced
this pull request
Feb 25, 2024
* Split CourseMap * Fix ppcdis upstream link * CourseMap: Field->System Co-authored-by: Theodoros Tyrovouzis <teotyrov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.