Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompile game/ui/Page #257

Merged
merged 7 commits into from
Feb 2, 2023
Merged

Decompile game/ui/Page #257

merged 7 commits into from
Feb 2, 2023

Conversation

GnomedDev
Copy link
Contributor

I'm incrementally decompiling each function as an intro to the project and to learn some cpp. Once it gets too advanced, I'll mark as merge-able.

Suggestions on improvements highly appreciated.

Copy link
Contributor

@vabold vabold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting should be run on the new pages.

source/game/ui/Page.hpp Outdated Show resolved Hide resolved
source/game/ui/Page.hpp Outdated Show resolved Hide resolved
source/game/ui/Page.hpp Outdated Show resolved Hide resolved
@GnomedDev GnomedDev marked this pull request as ready for review February 2, 2023 03:49
@riidefi riidefi merged commit dd89a1c into riidefi:master Feb 2, 2023
riidefi pushed a commit that referenced this pull request Feb 25, 2024
* Decompile Page::setAnimationDirection and Page::initChildren

* Decompile Page::startReplace

* Implement suggestions

* Decompile Page::insert and Page::setInputManager

* Decompile Page::skipInAnimation

* Decompile Page::skipOutAnimation

* Decompile Page::draw
@GnomedDev GnomedDev deleted the page-decomp branch April 26, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants