Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change LoaderArgs to DataFunctionArgs to support Remix V2 #38

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: change LoaderArgs to DataFunctionArgs to support Remix V2 #38

merged 1 commit into from
Sep 27, 2023

Conversation

setvik
Copy link
Contributor

@setvik setvik commented Sep 27, 2023

This PR addresses [BUG]: Typescript compilation fails in Remix V2 #37
allowing Typescript to compile Remix V2 projects with Zodix.

See linked issue for details, but TLDR is that LoaderArgs was renamed LoaderFunctionArgs in Remix V2. Since LoaderArgs/ActionArgs in V1 and LoaderFunctionArgs/ActionFunctionArgs in V2 are just aliases for DataFunctionArgs in both V1 and V2, we can fix this issue by simply swapping out the LoaderArgs references for DataFunctionArgs.

@rileytomasek
Copy link
Owner

Thanks, @setvik. I'll merge and publish a patch release right now.

@rileytomasek rileytomasek merged commit 76ddec7 into rileytomasek:master Sep 27, 2023
3 checks passed
@rileytomasek
Copy link
Owner

@setvik
Copy link
Contributor Author

setvik commented Sep 28, 2023

Works great. thanks much!

@setvik setvik deleted the fix-loaderargs-remix-v2 branch October 4, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants