Move to flat ESLint config #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangregoryholmes
requested review from
ericpgreen2
and removed request for
ericpgreen2
briangregoryholmes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves our ESLint configuration to the new flat config format, partly in preparation for ESLint v9 and partly to resolve a few issues with our monorepo setup. Legacy config versions are being deprecated.
To trigger linting across all repos, it changes all
rel="noreferrer"attributes to the correctrel="noreferrer noopenerand adds a key to the each block inweb-auth'sAuthcomponent.To enable the ESLint VSCode extension, you'll need to either install the latest prerelease in the marketplace or turn on
eslint.experimental.useFlatConfig, see: microsoft/vscode-eslint#1644Motivation: The use of
__dirnamein the current configuration does not correctly reference the correspondingtsconfig.jsonfor each project, which is at least one of the issues causing false positive ESLint warnings. The options to solve that are either move to the new flat config or have an additional ESLint configuration per repo.