Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(calculus, recognizer): memory leak due to unchecked regex error #172

Merged
merged 1 commit into from
Jan 17, 2018
Merged

fix(calculus, recognizer): memory leak due to unchecked regex error #172

merged 1 commit into from
Jan 17, 2018

Conversation

lotem
Copy link
Member

@lotem lotem commented Jan 16, 2018

Closes #171

@lotem lotem requested a review from Prcuvu January 16, 2018 16:35
@lotem lotem merged commit 19ddc1e into master Jan 17, 2018
@lotem
Copy link
Member Author

lotem commented Jan 17, 2018

Locally tested the build with Linux/gcc and macOS/clang. Merged.
Please verify the fix.

@lotem lotem deleted the fix branch January 17, 2018 15:23
@Prcuvu
Copy link
Contributor

Prcuvu commented Jan 18, 2018

Tested with Windows/MSVC and looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prcuvu Prcuvu Awaiting requested review from Prcuvu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lotem @Prcuvu