Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add rime_table_decompiler #706

Merged
merged 4 commits into from
Sep 4, 2023
Merged

tools: add rime_table_decompiler #706

merged 4 commits into from
Sep 4, 2023

Conversation

nopdan
Copy link
Contributor

@nopdan nopdan commented Sep 4, 2023

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

eagleoflqj
eagleoflqj requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Before approving ci I’d see the following:

boost/core Outdated Show resolved Hide resolved
tools/rime_table_decompiler.cc Outdated Show resolved Hide resolved
eagleoflqj
eagleoflqj requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good. Details to address before merging:

tools/rime_table_decompiler.cc Outdated Show resolved Hide resolved
tools/rime_table_decompiler.cc Outdated Show resolved Hide resolved
tools/rime_table_decompiler.cc Outdated Show resolved Hide resolved
tools/rime_table_decompiler.cc Outdated Show resolved Hide resolved
tools/rime_table_decompiler.cc Outdated Show resolved Hide resolved
tools/rime_table_decompiler.cc Outdated Show resolved Hide resolved
eagleoflqj
eagleoflqj approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes.
LGTM!

@eagleoflqj eagleoflqj merged commit 06a5c94 into rime:master Sep 4, 2023
@nopdan nopdan deleted the tools branch September 5, 2023 16:07
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
@nopdan @eagleoflqj @groverlynn
tools: add rime_table_decompiler (rime#706)
41c7776 
---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@nopdan @eagleoflqj @graphemecluster
tools: add rime_table_decompiler (rime#706)
25586ec 
---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@nopdan @eagleoflqj @graphemecluster
tools: add rime_table_decompiler (rime#706)
31f1920 
---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@nopdan @eagleoflqj @graphemecluster
tools: add rime_table_decompiler (rime#706)
40d9b5c 
---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@nopdan @eagleoflqj @graphemecluster
tools: add rime_table_decompiler (rime#706)
70ca155 
---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eagleoflqj eagleoflqj eagleoflqj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopdan @eagleoflqj