Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop boost regex lib for windows and macos #735

Merged
merged 1 commit into from
Oct 13, 2023
Merged

drop boost regex lib for windows and macos #735

merged 1 commit into from
Oct 13, 2023

Conversation

eagleoflqj
Copy link
Member

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Drop boost regex lib for windows and macos as it's been header-only since 1.77.
Keep it for Linux and wait for Ubuntu 24.04 GitHub Actions image.
Also drop librime-charcode as it's cumbersome and requires the last boost lib: locale.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@eagleoflqj eagleoflqj merged commit 298a9dd into rime:master Oct 13, 2023
8 checks passed
@eagleoflqj eagleoflqj deleted the boost-regex branch October 13, 2023 23:12
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@eagleoflqj @graphemecluster
drop boost regex lib for windows and macos (rime#735)
31cfb63
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@eagleoflqj @graphemecluster
drop boost regex lib for windows and macos (rime#735)
fb9a48c
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@eagleoflqj @graphemecluster
drop boost regex lib for windows and macos (rime#735)
b29503d
lotem added a commit that referenced this pull request Feb 9, 2024
@lotem
add back macOS script for building boost libraries
868e077 
boost_libs=<library> install-boost.sh --build

partically revert "drop boost regex lib for windows and macos (#735)"

This reverts install-boost.sh from commit 298a9dd.
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@eagleoflqj @graphemecluster
drop boost regex lib for windows and macos (rime#735)
0cf17b2
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@lotem @graphemecluster
add back macOS script for building boost libraries
1b2b9e1 
boost_libs=<library> install-boost.sh --build

partically revert "drop boost regex lib for windows and macos (rime#735)"

This reverts install-boost.sh from commit 298a9dd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eagleoflqj