Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge build scripts #759

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Merge build scripts #759

merged 4 commits into from
Nov 12, 2023

Conversation

WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@eagleoflqj eagleoflqj merged commit 78587b8 into rime:master Nov 12, 2023
8 checks passed
@WhiredPlanck WhiredPlanck deleted the merge-build branch November 12, 2023 02:40
fxliang pushed a commit to fxliang/librime that referenced this pull request Feb 2, 2024
* build: try to merge build.bat and build-clang.bat

* build: correct way to make opencc use prebuilt marisa on Windows

Co-authored-by: Ace-Who <subsistence99@163.com>

* build: slightly refactor to cmake user make rules

* deps: pick the latest marisa to fix include dir issue

---------

Co-authored-by: Ace-Who <subsistence99@163.com>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
* build: try to merge build.bat and build-clang.bat

* build: correct way to make opencc use prebuilt marisa on Windows

Co-authored-by: Ace-Who <subsistence99@163.com>

* build: slightly refactor to cmake user make rules

* deps: pick the latest marisa to fix include dir issue

---------

Co-authored-by: Ace-Who <subsistence99@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants