Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log file_path_ when warning in tsv.cc #825

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Feb 21, 2024

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lotem lotem merged commit 10cb298 into rime:master Feb 25, 2024
16 of 18 checks passed
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Feb 26, 2024
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Feb 26, 2024
@fxliang fxliang deleted the tsv_fp branch March 12, 2024 05:30
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants