fix(deployment_tasks): do not clean up log when not specify log dir #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotem
reviewed
Jul 21, 2024
WhiredPlanck
force-pushed
the
fix-20240721
branch
from
52d964c
to
d651ddb
Compare
lotem
approved these changes
Aug 15, 2024
ksqsf
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes # N/A
Feature
Describe feature of pull request
We now use
google::LogToStderr()instead ofFLAGS_logtostderr, thus when not specify log dir on RimeTraits,FLAGS_log_dirmust be empty, so use it to judge instead.Unit test
Manual test
Code Review
Additional Info