fix(navigator): wrong spans after selection #952
Merged
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cached spans can be wrong if not invalidated after selection.
Consider: aabbccdd which can be understood as both 'aa'bb'cc'dd' and 'aab'bcc'dd'.
Suppose the first candidate is from 'aa'bb'cc'dd'. Now do {Control+Right}{Right}{Space} to select the first candidate of aab. Now do {Control+Right} again:
This is because the spans are not recomputed even if we have picked a specific kind of segmentation. This PR adds a select handler and clears the spans to force the recomputation of the spans.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info