Skip to content

Commit

Permalink
fix: language bar icon not updated when thread changed
Browse files Browse the repository at this point in the history
  • Loading branch information
fxliang committed Apr 29, 2024
1 parent 2b9d968 commit c7b1df7
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
35 changes: 35 additions & 0 deletions WeaselTSF/WeaselTSF.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ WeaselTSF::WeaselTSF() {

_dwTextEditSinkCookie = TF_INVALID_COOKIE;
_dwTextLayoutSinkCookie = TF_INVALID_COOKIE;
_dwThreadFocusSinkCookie = TF_INVALID_COOKIE;
_fTestKeyDownPending = FALSE;
_fTestKeyUpPending = FALSE;

Expand Down Expand Up @@ -64,6 +65,8 @@ STDAPI WeaselTSF::QueryInterface(REFIID riid, void** ppvObject) {
*ppvObject = (ITfThreadFocusSink*)this;
else if (IsEqualIID(riid, IID_ITfDisplayAttributeProvider))
*ppvObject = (ITfDisplayAttributeProvider*)this;
else if (IsEqualIID(riid, IID_ITfThreadFocusSink))
*ppvObject = (ITfThreadFocusSink*)this;

if (*ppvObject) {
AddRef();
Expand Down Expand Up @@ -105,6 +108,8 @@ STDAPI WeaselTSF::Deactivate() {

_UninitCompartment();

_UninitThreadMgrEventSink();

_pThreadMgr = NULL;

_tfClientId = TF_CLIENTID_NULL;
Expand Down Expand Up @@ -151,6 +156,8 @@ STDAPI WeaselTSF::ActivateEx(ITfThreadMgr* pThreadMgr,

if (!_InitCompartment())
goto ExitError;
if (!_InitThreadFocusSink())
goto ExitError;

_EnsureServerConnected();

Expand All @@ -162,12 +169,40 @@ STDAPI WeaselTSF::ActivateEx(ITfThreadMgr* pThreadMgr,
}

STDMETHODIMP WeaselTSF::OnSetThreadFocus() {
if (m_client.Echo()) {
POINT pt{};
::GetCursorPos(&pt);
RECT rc{pt.x, pt.y, pt.x, pt.y};
m_client.UpdateInputPosition(rc);
m_client.ProcessKeyEvent(0);
weasel::ResponseParser parser(NULL, NULL, &_status, NULL, &_cand->style());
bool ok = m_client.GetResponseData(std::ref(parser));
if (ok)
_UpdateLanguageBar(_status);
}
return S_OK;
}
STDMETHODIMP WeaselTSF::OnKillThreadFocus() {
_AbortComposition();
return S_OK;
}
BOOL WeaselTSF::_InitThreadFocusSink() {
com_ptr<ITfSource> pSource;
if (FAILED(_pThreadMgr->QueryInterface(&pSource)))
return FALSE;
if (FAILED(pSource->AdviseSink(IID_ITfThreadFocusSink,
(ITfThreadFocusSink*)this,
&_dwThreadFocusSinkCookie)))
return FALSE;
return TRUE;
}
void WeaselTSF::_UninitThreadFocusSink() {
com_ptr<ITfSource> pSource;
if (FAILED(_pThreadMgr->QueryInterface(&pSource)))
return;
if (FAILED(pSource->UnadviseSink(_dwThreadFocusSinkCookie)))
return;
}

STDMETHODIMP WeaselTSF::OnActivated(REFCLSID clsid,
REFGUID guidProfile,
Expand Down
4 changes: 4 additions & 0 deletions WeaselTSF/WeaselTSF.h
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ class WeaselTSF : public ITfTextInputProcessorEx,
/* TSF Related */
BOOL _InitThreadMgrEventSink();
void _UninitThreadMgrEventSink();
// ITfThreadFocusSink
BOOL _InitThreadFocusSink();
void _UninitThreadFocusSink();
DWORD _dwThreadFocusSinkCookie;

BOOL _InitTextEditSink(com_ptr<ITfDocumentMgr> pDocMgr);

Expand Down

0 comments on commit c7b1df7

Please sign in to comment.