Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gcloud-sqlproxy] fix issue 134 - hpa metrics schema #136

Merged
merged 1 commit into from
Mar 29, 2023
Merged

[gcloud-sqlproxy] fix issue 134 - hpa metrics schema #136

merged 1 commit into from
Mar 29, 2023

Conversation

tomrk-esteam8
Copy link
Contributor

What this PR does / why we need it: This will fix an issue using autoscaling/v2 in hpa.

Which issue this PR fixes fixes #134

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped, is mandatory for any chart chnages
  • Title of the PR starts with chart name (e.g. [gcloud-sqlproxy])

rimusz
rimusz approved these changes Mar 29, 2023
View reviewed changes
Copy link
Owner

@rimusz rimusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rimusz rimusz merged commit 4338879 into rimusz:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimusz rimusz rimusz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcloud-sqlproxy - Helm Chart hpa fails using autoscaling/v2
2 participants
@tomrk-esteam8 @rimusz