Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcloud-sqlproxy] add extraFlags (single-hyphen arguments) for command #138

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

rverenich
Copy link
Contributor

What this PR does / why we need it:
At the moment --arg1=123 is possible to pass via extraArgs.
additional extraFlags added for possibilities to configure with flag-like -arg1 -arg2

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped, is mandatory for any chart chnages
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [gcloud-sqlproxy])

@rverenich
Copy link
Contributor Author

@rimusz , @naseemkullah , please take a look
Thanks in advance

Copy link
Owner

@rimusz rimusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rimusz rimusz merged commit 67e7d5d into rimusz:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants