[gcloud-sqlproxy] HPA kind Fix case sensitive StatefulSet #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of making a new version 0.25.6 .. if can just updated 0.25.5 that would be better. |
|
By any chance will this get merged or are you waiting to include it in the next version ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… sensitive StatefulSet #142
What this PR does / why we need it:
Which issue this PR fixes :
fixes #142
Special notes for your reviewer:
Stupid mistake by me in last PR since it looks like kind is case sensitive. Changed from Statefulset to StatefulSet.
I do not believe this needs a version bump. Should remain 0.25.5 but it looks like don't have an option to just patch 0.25.5 so bumped version
Again, sorry about this, this was actually my first PR to a public repo.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[gcloud-sqlproxy])