Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean tests, setup lint tools, improve errors #1

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Clean tests, setup lint tools, improve errors #1

merged 1 commit into from
Dec 25, 2020

Conversation

rinchsan
Copy link
Owner

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 20, 2020

Codecov Report

Merging #1 (90a0a06) into master (a3cfb5d) will decrease coverage by 0.07%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   90.85%   90.78%   -0.08%     
==========================================
  Files           9        9              
  Lines         164      141      -23     
==========================================
- Hits          149      128      -21     
  Misses          8        8              
+ Partials        7        5       -2     
Impacted Files Coverage Δ
client.go 100.00% <ø> (ø)
config.go 100.00% <ø> (ø)
jwt.go 83.33% <50.00%> (-3.34%) ⬇️
query.go 78.26% <76.47%> (-9.24%) ⬇️
validate.go 82.35% <83.33%> (-5.89%) ⬇️
update.go 84.21% <85.71%> (-5.27%) ⬇️
api.go 100.00% <100.00%> (+18.75%) ⬆️
credential.go 100.00% <100.00%> (ø)
error.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3cfb5d...90a0a06. Read the comment docs.

@rinchsan rinchsan force-pushed the update branch 15 times, most recently from a9a5102 to a85fbc7 Compare December 25, 2020 17:02
@rinchsan rinchsan changed the title update Clean tests, setup lint tools, improve errors Dec 25, 2020
@rinchsan rinchsan merged commit 96ccb68 into master Dec 25, 2020
@rinchsan rinchsan deleted the update branch December 25, 2020 17:16
@rinchsan rinchsan added the minor Minor changes label Dec 26, 2020
rinchsan pushed a commit that referenced this pull request Jan 13, 2021
try to properly handle the case where the bits are not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants