Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors and improve test #35

Merged
merged 3 commits into from
Oct 9, 2021
Merged

Fix lint errors and improve test #35

merged 3 commits into from
Oct 9, 2021

Conversation

rinchsan
Copy link
Owner

@rinchsan rinchsan commented Oct 9, 2021

  • Fixed golangci-lint errors
  • Upgraded golangci-lint version
  • Added test for invalid credential files

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #35 (c1330b2) into main (849f8c0) will decrease coverage by 3.66%.
The diff coverage is 52.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   95.77%   92.10%   -3.67%     
==========================================
  Files           9        9              
  Lines         213      228      +15     
==========================================
+ Hits          204      210       +6     
- Misses          6       12       +6     
- Partials        3        6       +3     
Impacted Files Coverage Δ
query.go 79.06% <33.33%> (-12.60%) ⬇️
jwt.go 87.50% <40.00%> (-12.50%) ⬇️
credential.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 849f8c0...c1330b2. Read the comment docs.

@rinchsan rinchsan changed the title Improve test Fix lint errors and improve test Oct 9, 2021
@rinchsan rinchsan merged commit ddbdb54 into main Oct 9, 2021
@rinchsan rinchsan deleted the improve-test branch October 9, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant