Expose more options, avoid descriptor exhaustion crashes, improve documentation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bit that handles descriptor exhaustion is related to issue #21, which I had replied to via email but apparently never appeared on GitHub. Sorry about that. If you have any thoughts, I'd love to hear them. Otherwise, my changes are pretty minimal. |
ringabout
reviewed
Mar 21, 2023
ringabout
reviewed
Mar 21, 2023
ringabout
reviewed
Mar 21, 2023
|
Thanks! Happy to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've exposed more options to the user via compile time consts that can be defined by the user, and I've also improved documentation in various areas that were bare.
I've also wrapped acceptClient in a try...except that ignores descriptor exhaustion errors, which fixes the ability for anyone to overload the server with connections and crash it.
Additionally, serverInfo has been renamed to httpxServerName (but the old constant still works), and defining it as empty will omit it from the HTTP response. Some users may not want to expose which HTTP server they're using to serve requests, and I think this would be a good thing to have as an option.