Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename blockNumber to blockHeight to avoid naming conflicts with the indexer #104

Closed
hujw77 opened this issue Jan 22, 2024 · 0 comments
Closed

Rename blockNumber to blockHeight to avoid naming conflicts with the indexer #104

hujw77 opened this issue Jan 22, 2024 · 0 comments
Assignees
@hujw77

Comments

@hujw77
Copy link
Collaborator

hujw77 commented Jan 22, 2024

https://github.com/darwinia-network/ORMP/blob/7208d80d0e57c192964f9c5e0432d878756f5aa7/src/eco/OracleV2.sol#L27
@hujw77 hujw77 self-assigned this Jan 22, 2024
@hujw77 hujw77 changed the title Rename blockNumber to blockHeaderNumber to avoid naming conflicts with the indexer Rename blockNumber to blockHeight to avoid naming conflicts with the indexer Jan 22, 2024
hujw77 added a commit that referenced this issue Jan 22, 2024
@hujw77
fix #104
a0e7835
@hujw77 hujw77 closed this as completed in 8f45197 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hujw77 hujw77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hujw77