Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Content-Encoding values case-insensitive #354

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Accept Content-Encoding values case-insensitive #354

merged 1 commit into from
Oct 3, 2016

Conversation

grob
Copy link
Member

@grob grob commented Oct 2, 2016

According to the spec the value of the content-encoding header field
is case insensitive, therefor changed readResponse() to utilize
equalsIgnoreCase() when checking the content encoding.

See https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.5

According to the spec the value of the content-encoding header field
is case insensitive, therefor changed `readResponse()` to utilize
`equalsIgnoreCase()` when checking the content encoding.

See https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.5
@mention-bot
Copy link

@grob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hns, @botic and @kmfdm1 to be potential reviewers.

@botic botic merged commit 0ffad94 into ringo:master Oct 3, 2016
@botic
Copy link
Member

botic commented Oct 3, 2016

Thx for the PR!

@grob grob deleted the httpclient-content-encoding branch October 3, 2016 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants