Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version numbers to v0.3.0 #107

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

Kijewski
Copy link
Collaborator

@Kijewski Kijewski commented Aug 1, 2024

  • rinja 0.2.1 is backward compatible to v0.2.0, only adding new functions traits, not changing existing ones
  • rinja_derive 0.3.0 emits code that uses e.g. rinja::helpers::get_primitive_value() which were not present in rinja 0.2.0, so it is not backward compatible
  • rinja_parser introduces new enum members, so it is not backward compatible

Resolves #101.

@GuillaumeGomez
Copy link
Contributor

I'd prefer if we kept the same version number across all crates. Makes it simpler for users to know what's going on instead of trying to remember which version of X maps to Y.

@Kijewski
Copy link
Collaborator Author

Kijewski commented Aug 1, 2024

Then we must either

  • bump the version of rinja to 0.3.0, too, even though it is not a breaking change, or
  • pin the rinja_derive version in rinja, and the rinja_parser version in rinja_derive, but accept that people who update only one of the dependencies are in for trouble, or
  • do both, so for later releases we can update the pinned version, making later releases easier.

Then I'd prefer the 3rd solution:

rinja/Cargo.toml: version = "0.3.0", rinra_derive = "=0.3.0"
rinja_derive/Cargo.toml: version = "0.3.0", rinra_parser = "=0.3.0"
rinja_parser/Cargo.toml: version = "0.3.0"

@GuillaumeGomez
Copy link
Contributor

I'd update all versions to 0.3.0 so all rinja crates are equal (in version) to each others.

@Kijewski Kijewski changed the title Bump version numbers for Rinja v0.2.1 Bump version numbers to v0.3.0 Aug 1, 2024
@@ -25,7 +25,8 @@ with-rocket = []
with-warp = []

[dependencies]
parser = { package = "rinja_parser", version = "0.2.0", path = "../rinja_parser" }
parser = { package = "rinja_parser", version = "=0.3.0", path = "../rinja_parser" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here and below.

@Kijewski Kijewski merged commit 197680f into rinja-rs:master Aug 2, 2024
17 checks passed
@Kijewski Kijewski deleted the pr-v0.2.1 branch August 2, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ready for v0.3.0?
2 participants