derive: replace ahash
with rustc-hash
#137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ahash
shines when you hash very long inputs, in excess of 1000 bytes. We only hash file names, variable names, block names … which should for all reasonable applications less than 100 bytes in length.rustc-hash
does not claim to be DoS-resistent likeahash
is, but we only operate on trusted data, so this feature is not needed.See also: https://blog.goose.love/posts/rosetta-hashing/.
The performance is mostly unchanged or slightly improved: