parser: add optional {% endwhen %}
#165
Conversation
rinja_parser/src/node.rs
Outdated
| let comment = Comment { | ||
| ws: Ws(pws, nws), | ||
| content: "", | ||
| }; | ||
| Node::Comment(WithSpan::new(comment, span)) |
There was a problem hiding this comment.
The implementation is kinda lazy, that I add a "virtual" comment node. But I guess it's good enough for the foreseeable future. :)
There was a problem hiding this comment.
Please add a comment on this code so future us won't wonder why there is a comment generated here. 😆
There was a problem hiding this comment.
Hehe, yeah, makes sense to write comments in a place where you would actually find them. :D
book/src/template_syntax.md
Outdated
| @@ -619,6 +619,11 @@ You can also match against multiple alternative patterns at once: | |||
| {% endmatch %} | |||
| ``` | |||
|
|
|||
| For better interoperability with linters and auto-formatters like [djLint], | |||
| you can also use a optional `{% endwhen %}` node to close a `{% when %}` case. | |||
There was a problem hiding this comment.
Maybe add an example?
Kijewski
force-pushed
the
pr-endmatch
branch
from
7655077 to
d3c3a63
Compare
Kijewski
force-pushed
the
pr-endmatch
branch
from
d3c3a63 to
f1d4c1b
Compare
|
Thank you for putting in the work on this @Kijewski! To be honest, I am unfamiliar with It is very small and insignificant for most, but every time I need to manually format something I feel it take a chunk of my soul. It is much appreciated |
I think we had the same question before in askama, but I cannot find the issue. Even though I don't use djLint or similar linters, I can see how this feature can be useful to people that do.
Resolves #163.
Cc @chrisp60.