Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: make {#-#} a syntax error #169

Merged
merged 1 commit into from
Sep 11, 2024
Merged

parser: make {#-#} a syntax error #169

merged 1 commit into from
Sep 11, 2024

Conversation

Kijewski
Copy link
Collaborator

Resolves #168.

@GuillaumeGomez
Copy link
Contributor

I'll review after rebase. 😉

@GuillaumeGomez
Copy link
Contributor

GuillaumeGomez commented Sep 11, 2024 •
edited
Loading

Thanks! Not completely convinced by the not-sealed approach for the trait but we can always revisit it later on.

EDIT: Commented on the wrong PR of course. XD

@GuillaumeGomez GuillaumeGomez merged commit 8bb1434 into rinja-rs:master Sep 11, 2024
34 checks passed
@Kijewski Kijewski deleted the pr-ambiguous-raw branch September 11, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make {#-#} a syntax error?
2 participants
@Kijewski @GuillaumeGomez