Deny all rust keywords as macro names #23
Conversation
|
Please add a ui test too please. |
There always is a test for super: macro-super.rs. Should I add tests for the other keywords, too? |
|
|
||
| /// Ensure that all strings are UTF-8, because we use `from_utf8_unchecked()` further down. | ||
| #[test] | ||
| fn ensure_utf8() { |
There was a problem hiding this comment.
Is there a need to duplicate these consts between the two crates? Can't we make them public behind #[doc(hidden)] instead?
There was a problem hiding this comment.
Is there a need to duplicate these consts between the two crates?
Sadly, I think yes. The list items are not the same with loop self Self missing from the generator list.
There was a problem hiding this comment.
Then why not add another list for these 3 keywords in rinja_parser? Having some much code duplicated is itching me strongly. ^^'
If you want I don't mind doing it. In this case just merge this PR and I'll take a look.
There was a problem hiding this comment.
In this case just merge this PR and I'll take a look.
Thanks! Sure, go ahead. :)
Oh if there is one already then it's fine. 👍 |
Per https://github.com/djc/askama/pull/1044#discussion_r1602289767.