Improve Level API a bit #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kijewski
requested changes
Jun 23, 2024
rinja_parser/src/lib.rs
Outdated
| fn nest<'b, T, F: FnMut(&'b str) -> ParseResult<'b, T>>( | ||
| &self, | ||
| i: &'b str, | ||
| mut callback: F, |
There was a problem hiding this comment.
F can be FnOnce. Currently that does not matter, but maybe we refactor the parser code later.
rinja_parser/src/lib.rs
Outdated
| i: &'b str, | ||
| mut callback: F, | ||
| ) -> ParseResult<'b, T> { | ||
| let prev_level = self.level.get(); | ||
| let (_, level) = self.level.get().nest(i)?; |
There was a problem hiding this comment.
You could directly call prev_level.nest(i).
Comment on lines
-93
to
-96
| let (i, _) = s.nest(j)?; | ||
| let result = func(i, s); | ||
| s.leave(); | ||
| let (i, node) = result?; |
There was a problem hiding this comment.
It is much clearer what is going on with your change, and the code does look much more nom-like. Clear advancement!
GuillaumeGomez
force-pushed
the
improve-level-api
branch
from
892d968 to
3c9e85a
Compare
|
There is still the original Something for later on. :) |
GuillaumeGomez
force-pushed
the
improve-level-api
branch
from
3c9e85a to
4b847a2
Compare
|
Fixed CI. :) |
Kijewski
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #30.
It already improves the situation a bit. Not sure if the rest is worth improving or not though.