-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example app #52
Add example app #52
Conversation
It's a very good idea! And basically, any example is better than no examples. 😉 |
f96bb6f
to
6638c33
Compare
</h2> | ||
|
||
<ul id="lang-select"> | ||
{%- if lang != Lang::en -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question: shouldn't it be ==
and also else if
following?
|
||
<ul id="lang-select"> | ||
{%- if lang != Lang::en -%} | ||
<li><a href="{{ req.url_for("index_handler", [Lang::en])? }}">This page in English</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li><a href="{{ req.url_for("index_handler", [Lang::en])? }}">This page in English</a></li> | |
<li><a href="{{ req.url_for("index_handler", [Lang::en])? }}">This page is in English.</a></li> |
Why not using an array then? |
Sorry, I don't follow. What array? |
Nevermind. However, there is duplicated code between |
I made the language selection footer a macro, to show that we have macros and how to use them. An |
I think it's a good idea. Well done! |
Thanks! And thank you for your reviews! :) |
I thought: We explain a lot in the book, use all functions in the tests, but we have no real example application so you can see rinja in action in a half-way realistic setting.
Todo:
If that is a good example, I don't know. I was too lazy to write the ubiquitous TODO-app example.