-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add fully qualified Names for method parameters, return types, new constructor call and generic types #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. The same needs to be applied at other places, not only parameters, doesn't it?
Eg. Return types, new constructor calls, generic types, ...
Also all test assertions need to be updated (not only the snapshots, but also TestHelper.GenerateMapper(...
calls).
Could you adjust your commit message to not only refer to the issue but include a short description of what is beeing fixed. This shows up in the release notes.
Hey @latonz Hi there! I've made a contribution by committing changes to the codebase. I would greatly appreciate it if you could review my changes and provide feedback. I have thoroughly tested the changes and believe they improve the overall functionality and quality of the project. However, I am open to any suggestions or changes that you may have to further enhance the code. Here's a brief overview of the changes I made:
Please let me know if there are any additional changes or improvements you would like me to make. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
You may also need to update the integration tests.
…ion method to static closes riok#298
I resolved test issues Please let me know if there are any other additional changes or improvements you would like me to make. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments 😊 A few smaller feedbacks, looks good otherwise 👍
…ierName(t.NonNullable()) riok#298
Thanks for feedback. I updated code according to your feedback. Please let me know if there are any other additional changes or improvements you would like me to make. Thank you! |
Resolved all integration test issues Please let me know if there are any other additional changes or improvements you would like me to make. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few linter issues. Some of them can be fixed with dotnet format
and verified with dotnet format --verify-no-changes && dotnet build -c Release
others may need manual fixes.
test/Riok.Mapperly.IntegrationTests/Riok.Mapperly.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
Resolved all issues Please let me know if there are any other additional changes or improvements you would like me to make. Thank you! |
Could you squash your commits together in one feature commit according to the conventional commits specification? The title of the PR should do the job as commit message. There are some more minor linter errors to be fixed. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 91.71% 91.78% +0.06%
==========================================
Files 109 117 +8
Lines 3379 3724 +345
Branches 438 506 +68
==========================================
+ Hits 3099 3418 +319
- Misses 189 209 +20
- Partials 91 97 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Resolved all lint issues Please let me know if there are any other additional changes or improvements you would like me to make. Thank you! |
🎉 This PR is included in version 2.8.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Resolved #298
Old Generated Code
New Generated Code
Please review and provide feedback on the changes. Thank you!