Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not diagnostic property not found if target is read only #345

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix: do not diagnostic property not found if target is read only #345

merged 1 commit into from
Apr 18, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Apr 16, 2023

Closes #329

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2023

Codecov Report

Merging #345 (9e176b8) into main (dce4b42) will increase coverage by 0.22%.
The diff coverage is 92.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   91.71%   91.93%   +0.22%     
==========================================
  Files         109      121      +12     
  Lines        3379     3833     +454     
  Branches      438      520      +82     
==========================================
+ Hits         3099     3524     +425     
- Misses        189      210      +21     
- Partials       91       99       +8     
Impacted Files Coverage Δ
src/Riok.Mapperly.Abstractions/MapEnumAttribute.cs 100.00% <ø> (ø)
...berMappings/MemberNullDelegateAssignmentMapping.cs 57.14% <0.00%> (ø)
.../Mappings/NewInstanceObjectFactoryMemberMapping.cs 100.00% <ø> (ø)
...Mapperly/Descriptors/UserMethodMappingExtractor.cs 98.38% <50.00%> (ø)
...riptors/MappingBuilders/QueryableMappingBuilder.cs 68.42% <68.42%> (ø)
...Descriptors/Mappings/EnumFromStringParseMapping.cs 73.68% <73.68%> (ø)
...ptors/Mappings/MemberMappings/NullMemberMapping.cs 76.27% <76.27%> (ø)
src/Riok.Mapperly/Symbols/FieldMember.cs 78.57% <78.57%> (ø)
src/Riok.Mapperly/Symbols/PropertyMember.cs 78.57% <78.57%> (ø)
...lders/NewInstanceObjectMemberMappingBodyBuilder.cs 80.17% <80.17%> (ø)
... and 57 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz requested a review from CommonGuy April 16, 2023 18:51
@latonz latonz enabled auto-merge (squash) April 18, 2023 07:03
@latonz latonz requested a review from CommonGuy April 18, 2023 07:03
@latonz latonz merged commit 6ec7e80 into riok:main Apr 18, 2023
@latonz latonz deleted the 329-no-diagnostics-when-target-is-read-only branch April 18, 2023 07:23
@github-actions
Copy link

🎉 This PR is included in version 2.8.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyzer should ignore readonly properties in target
3 participants