Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riot fails to build with OCaml 5.2 #89

Closed
dmmulroy opened this issue Jul 12, 2024 · 2 comments · Fixed by #94
Closed

Riot fails to build with OCaml 5.2 #89

dmmulroy opened this issue Jul 12, 2024 · 2 comments · Fixed by #94

Comments

@dmmulroy
Copy link
Contributor

> File "riot/lib/ssl.ml", line 97, characters 11-47:
       > 97 |       | Ok (state', `Response resp, `Data data) ->
       >                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       > Error: This pattern matches values of type 'a * 'b * 'c
       >        but a pattern was expected which matches values of type
       >          Tls.Engine.state * [ `Eof ] option *
       >          [ `Response of Cstruct.t option ] * [ `Data of Cstruct.t option ]
Copy link

linear bot commented Jul 12, 2024

@dmmulroy dmmulroy changed the title Riot fails to build with OCaml 5.2 Riot fails to build Jul 12, 2024
@dmmulroy dmmulroy changed the title Riot fails to build Riot fails to build with OCaml 5.2 Jul 12, 2024
@leostera
Copy link
Collaborator

Hmm, looks like we'll have to refactor some of the TLS code. I wonder why we're picking up a new version or if they are doing some conditional compilation based off the compiler version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants