Update handle_tls to support latest tls version #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #89 |
|
So this is failing in CI building on 5.1. Not surprised. If there's not conditional compilation based on compiler version, perhaps we just need a 5.2 branch for the time being? Not sure how that's handled in OCaml land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested this yet, just that it builds on OCaml 5.2 and the tests pass (i.e.
dune test). I based the changes off of what was changed in theocaml-tlsrepo for theeiosubpackage as referenced at the top of ssl.ml, that diff is here. Note that the diff for ocaml-tls/eio is not very clean due to another change they were making as well, but I believe I brought over the necessary changes.This is mostly to support the latest tls that's used in the package set for OCaml 5.2 as used in the nix-ocaml overlay. We could alternatively pin back to the 0.17.3 version manually in the flake if you prefer.