-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgraded dependencies #44
Conversation
2c21740
to
0bc11ac
Compare
Could you try to make it work with ZF ~ 2.5 too? |
@leogr Yes of course, Thanks for reminding me about those. |
It seems to work with ZF 2.4 to 2.7, but not with zend-service-manager 3.0. due to BCs introduced within the new ServiceManager. With zend-service-manager 3.0 I got the following error in a lot of tests: @fntlnz Could you try to investigate about this issue? Let me know. |
@leogr since you're already working on this we may close this PR. Let me know if you need any help. |
I fixed all compatibilities issue, now it works from 2.4 up to 3.0 (see the last build). @fntlnz if you rebase your PR then I merge the travis config, that can be very useful. |
5410da2
to
f9ab94a
Compare
@leogr done! |
All seems to be working pretty fine also with lower bound deps https://travis-ci.org/ripaclub/sphinxsearch/builds/118620431 |
While working on a project that is using zend-*thing ~ 2.7 I wasn't able to use this anymore.
In this branch I'm working on checking if zendframework dependencies can be updated safely without breaking changes and if the whole project is compatibile with PHP 7.
Note: This is a work in progress. I needed the PR to run tests on travis.