Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgraded dependencies #44

Merged
merged 8 commits into from
Mar 26, 2016
Merged

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Mar 15, 2016

While working on a project that is using zend-*thing ~ 2.7 I wasn't able to use this anymore.
In this branch I'm working on checking if zendframework dependencies can be updated safely without breaking changes and if the whole project is compatibile with PHP 7.

Note: This is a work in progress. I needed the PR to run tests on travis.

@fntlnz fntlnz force-pushed the upgrade-dependencies branch from 2c21740 to 0bc11ac Compare March 15, 2016 17:18
@leogr
Copy link
Contributor

leogr commented Mar 17, 2016

Could you try to make it work with ZF ~ 2.5 too?
There are a lot of people are still using the 2.5.
You can use polyfills like these.

@fntlnz
Copy link
Contributor Author

fntlnz commented Mar 21, 2016

@leogr Yes of course, Thanks for reminding me about those.

@leogr
Copy link
Contributor

leogr commented Mar 25, 2016

It seems to work with ZF 2.4 to 2.7, but not with zend-service-manager 3.0. due to BCs introduced within the new ServiceManager.

With zend-service-manager 3.0 I got the following error in a lot of tests:
Argument 1 passed to Zend\ServiceManager\ServiceManager::__construct() must be of the type array, object given
I think the only issue is about the two factory classes or may be just the tests are incompatible, not the library itself.

@fntlnz Could you try to investigate about this issue? Let me know.

@fntlnz
Copy link
Contributor Author

fntlnz commented Mar 26, 2016

@leogr since you're already working on this we may close this PR. Let me know if you need any help.

@leogr
Copy link
Contributor

leogr commented Mar 26, 2016

I fixed all compatibilities issue, now it works from 2.4 up to 3.0 (see the last build).

@fntlnz if you rebase your PR then I merge the travis config, that can be very useful.

@fntlnz fntlnz force-pushed the upgrade-dependencies branch from 5410da2 to f9ab94a Compare March 26, 2016 02:59
@fntlnz
Copy link
Contributor Author

fntlnz commented Mar 26, 2016

@leogr done!

@fntlnz
Copy link
Contributor Author

fntlnz commented Mar 26, 2016

All seems to be working pretty fine also with lower bound deps

https://travis-ci.org/ripaclub/sphinxsearch/builds/118620431

@leogr leogr merged commit 7e3cb1d into ripaclub:master Mar 26, 2016
leogr added a commit that referenced this pull request Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants