Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: black formatter #38

Merged
merged 7 commits into from
Apr 29, 2022
Merged

feat: black formatter #38

merged 7 commits into from
Apr 29, 2022

Conversation

joao-conde
Copy link
Contributor

@joamag main differences are:

  • trailing commas in sequences
  • no space between the equals (=) in kwargs key and value

Example black config properties: https://github.com/psf/black/blob/main/pyproject.toml

An interesting read: https://luminousmen.com/post/my-unpopular-opinion-about-black-code-formatter

Maybe black is too opinionated for us and not configurable enough?

@joao-conde joao-conde added enhancement New feature or request fast-track Feature to be fixed or implemented ASAP labels Apr 29, 2022
@joao-conde joao-conde requested a review from joamag April 29, 2022 17:38
@ripe-tobias-bot
Copy link

Woof, Woof!

Thank you @joao-conde for submitting the "feat: black formatter" pull request 😎.

Please do not forget to review our internal guidelines:

  • Review the code in the PR using a peer 🧑‍🤝‍🧑
  • Make sure all the linting process has been executed an passed 👌
  • Make sure unit tests are passing ✅
  • Ensure that proper code standards are met 📋
  • Fill in the PR's summary (issue, dependencies, decisions and GIF)
  • Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@ripe-tobias-bot
Copy link

Woof, Woof!

Oops! @joao-conde you may have to fix some errors:

  • You either forgot to add the no-changelog label to this PR, or to log the changes in CHANGELOG.md file. Please try to fix this and then re-assign PR. ❗️
  • Please specify a link to the issue or rationale in the description of the PR ❗️

Please address these issues to continue with the Pull Request merge process.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@ripe-tobias-bot ripe-tobias-bot bot assigned joao-conde and unassigned joamag Apr 29, 2022
@coveralls
Copy link

coveralls commented Apr 29, 2022

Pull Request Test Coverage Report for Build 208

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 198: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@joamag joamag merged commit 48adeb1 into master Apr 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the jc/feat-black-formatter branch April 29, 2022 19:03
@joamag
Copy link
Contributor

joamag commented Apr 29, 2022

OK, this one is merged, let's start exploring new ones @joao-conde 🌈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fast-track Feature to be fixed or implemented ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants