Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import order simple #46

Merged
merged 2 commits into from
Jul 26, 2022
Merged

feat: import order simple #46

merged 2 commits into from
Jul 26, 2022

Conversation

joao-conde
Copy link
Contributor

- -
Issue https://github.com/ripe-tech/ripe-bridge/issues/302
Dependencies --
Decisions Expose import order simple in the API client.
Animated GIF --

@ripe-tobias-bot
Copy link

Woof, Woof!

Thank you @joao-conde for submitting the "feat: import order simple" pull request 😎.

Please do not forget to review our internal guidelines:

  • Review the code in the PR using a peer 🧑‍🤝‍🧑
  • Make sure all the linting process has been executed an passed 👌
  • Make sure unit tests are passing ✅
  • Ensure that proper code standards are met 📋
  • Fill in the PR's summary (issue, dependencies, decisions and GIF)
  • Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@joao-conde joao-conde added the enhancement New feature or request label Jul 26, 2022
@joao-conde joao-conde requested a review from joamag July 26, 2022 11:23
@coveralls
Copy link

coveralls commented Jul 26, 2022

Pull Request Test Coverage Report for Build 262

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 36.033%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ripe/order.py 1 4 25.0%
Totals Coverage Status
Change from base Build 258: -0.05%
Covered Lines: 347
Relevant Lines: 963

💛 - Coveralls

@joamag joamag merged commit b5a4bf6 into master Jul 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the jc/feat-import-order-simple branch July 26, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants