Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Replace custom tab manager with ngView #270

Closed
justmoon opened this issue Feb 28, 2013 · 1 comment
Closed

Replace custom tab manager with ngView #270

justmoon opened this issue Feb 28, 2013 · 1 comment

Comments

@justmoon
Copy link
Contributor

Right now we are using a custom TabManager class for loading and rendering tabs instead of the native Angular ngView. We did this originally because of certain limitations in Angular.js.

@justmoon
Copy link
Contributor Author

One thing that Angular does not currently support is nested views:

angular/angular.js#1291

We are currently only using nested views for one thing: Tabs that have a menu and sub-tabs. We can probably refactor that so that it doesn't actually use nested views, but rather just include the menu html on each individual tab.

We're also using a dirty hack for making the injector extensible:

angular/angular.js#1721

Ideally, the Angular team would finish the hierarchical injector. But as far as I can tell our hack still works fine even if we switch to ng-view.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant