-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Support multiple ng-view on a page and nested ng-view #1291
Conversation
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): For corporations (print, sign and scan+email, fax or mail): |
CLA: done! |
Is this going to be merged? I'd love to be able to use this change. |
+1. Any update? This would be a great addition |
+1 I think that is very important in any JS framework to have multiple views. |
+1 for this too |
5 months ago...can we get a status update on this? |
I am very sorry about the delay. I have looked at this again, and unfortunately I don't think this can be merged in the current state. The issue is that your change allows multiples views to be changed at once (this is good) but all of the views will get a different instance of the same controller Type. This is probably not what you want. At the very least the views should either share the same instance, or better yet each get their own instance but of their own Type. If they all have different controller types, then there must be a way for the controllers to be able to communicate through some shared service which is route scoped not application scoped. This last part will require a different injection system. Also the change is missing sufficient documentation for others to use this feature. I am going to close this issue for now, so that we can get a better handle on our PRs. If you correct the above issues, please reopen the PR. |
Please disregard the two old commits in this PR. I'm not sure what I did, I'm not really used to git.
The only commit that matters is 301cc9b.