This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
[FIX] History: show price for orders (RT-1385) #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@darkdarkdragon please rebase |
darkdarkdragon
force-pushed
the
develop-RT-1385
branch
2 times, most recently
from
5460719 to
fa9bb09
Compare
| span(rp-span-spacing) : | ||
| strong(rp-address-popover, rp-address-popover-sum="effect.invStraightPrice") {{effect.invStraightPrice | rpamount:{abs_precision: 6} }} | ||
| span {{ effect.pays | rpcurrency }} | ||
| | per |
darkdarkdragon
force-pushed
the
develop-RT-1385
branch
2 times, most recently
from
1ecd532 to
2d74359
Compare
In history for orders show price in format prce: x CURRENCY per CURRENCY (like "You sold .002046 BTC for 51.15048 XRP (price: 25,000 XRP per BTC)")
darkdarkdragon
force-pushed
the
develop-RT-1385
branch
from
2d74359 to
96965b9
Compare
|
@vhpoet Please look at changes to json rewriter. |
| @@ -26,6 +26,30 @@ var getPrice = function(effect, referenceDate) { | |||
| return price || 0; | |||
| }; | |||
|
|
|||
| var getStraightPrice = function(effect, referenceDate) { | |||
| var g = effect.got ? effect.got : effect.gets; | |||
There was a problem hiding this comment.
var g = effect.got ? effect.got : effect.gets
is the same as
var g = effect.got || effect.gets
There was a problem hiding this comment.
thanks! I tend to forget that notation :)
|
LGTM |
mrajvanshy
added a commit
that referenced
this pull request
May 11, 2015
[FIX] History: show price for orders (RT-1385)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In history for orders show price in format
prce: x CURRENCY per CURRENCY (like
"You sold .002046 BTC for 51.15048 XRP (price: 25,000 XRP per BTC)")