This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
RT build process just got so much cooler #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert jade files to html and load them with ajax on the fly
Fixes a problem with the jade compilation
There's only one index file, everything that needs to be translated should go to layout file.
app.js doesn't contain translatable strings anymore.
vhpoet
changed the title
|
LGTM |
|
@vhpoet Can you fix the 2 or 3 failing tests? |
use ng-html2js preprocessor to load templates in karma tests
[TEST] fix karma tests (RT-3361)
|
LGTM |
mrajvanshy
added a commit
that referenced
this pull request
Apr 16, 2015
RT build process just got so much cooler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile templates separate from the logic.
There's gonna be only one app.js file, and a folder with the translated templates for each language.
Templates are gonna be loaded dynamically based on usage.
New app.js is 290kb. Comapre it to the old 1.2mb