This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
Check and log transactions (RT-3499 - RT-3501) #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0vhannes
changed the title
h0vhannes
changed the title
| return $http.put(Options.backend_url + '/api/subscription', subscription, httpOptions); | ||
| }; | ||
|
|
||
| rpAPI.addTransaction = function(transaction, result, hash, local_time) { |
There was a problem hiding this comment.
Wouldn't logTransaction be a better name for this?
There was a problem hiding this comment.
add is used to keep CRUD logic, log sounds better for sure.
|
The naming convention for angular dependencies is
so |
|
Totally agree with this one. I was just confused because this convention is not preserved everywhere, so that's why I used $api in a number of places. But I'll change that. |
|
@vhpoet - fixed, please have a look |
|
LGTM |
MatthewPhinney
added a commit
that referenced
this pull request
Sep 24, 2015
Check and log transactions (RT-3499 - RT-3501)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.