Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credentials related transactions #30

Merged
merged 5 commits into from
Feb 19, 2025
Merged

Credentials related transactions #30

merged 5 commits into from
Feb 19, 2025

Conversation

Patel-Raj
Copy link
Collaborator

Added Credentials Transactions:

  1. CredentialAccept
  2. CredentialCreate
  3. CredentialDelete

pdp2121
pdp2121 reviewed Feb 19, 2025
View reviewed changes
shared/transactions/credential_create.yaml
Subject:
type: string
description: The subject of the credential.
URI:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a max length of 256 for uri

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it's should be a valid hex

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added maxLength of 512 characters as 1 byte accommodates two hex values

@pdp2121 pdp2121 merged commit 3adb1bf into ripple:main Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdp2121 pdp2121 pdp2121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patel-Raj @pdp2121