Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-4217: Add “page source” links to preview-src pages #101

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

eric-schneider
Copy link
Contributor

@eric-schneider eric-schneider commented Feb 20, 2024

Jira: DOC-4217

The docs-ui preview is going to be used more frequently by writers as a reference for AsciiDoc formatting. As such, writers will need quick access to the AsciiDoc source files for each of the pages in the preview to view the underlying syntax. However, because the “Edit this page” button isn't present in the preview, we should manually specify the source file link at the top of each preview source page.

Draft example: https://riptano.github.io/docs-ui/DOC-4217-preview-source-links/asciidoc/text-formatting.html

In addition, the README is out of date with some of the latest enhancements to docs-ui automation. I've made a first high-level pass at documenting these changes.

README preview: https://github.com/riptano/docs-ui/blob/c33a5775e295efffde64f3207920ae1028780ba6/README.adoc

@mlr
Copy link
Contributor

mlr commented Feb 20, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Feb 20, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Feb 20, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Feb 20, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@eric-schneider eric-schneider requested a review from mlr February 20, 2024 23:54
Copy link
Collaborator

@colegoldsmith colegoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements

@eric-schneider eric-schneider merged commit 565311f into main Feb 26, 2024
2 checks passed
@eric-schneider eric-schneider deleted the DOC-4217-preview-source-links branch February 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants